Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Modifying or changing focus on composite bindings in the Input Actions Editor no longer cause a full UI rebuild #2094

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Secticide
Copy link
Collaborator

Description

Fixes ISXB-1171.

The issue was caused by the on change handler causing a full UI rebuild of the editor window when it was not required. The fix required added a new enum which told the UI system if a rebuild was necessary - defaulting to rebuilding since this was the previous default.

Testing status & QA

This was tested locally using the provided project. The change is localised to the composite binding part of the window and so I don't believe additional QA would be required.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

The only concern I have with this solution is - do we know of any instances where changes to the UI would require a complete rebuild?

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

… the state container dispatch and view base OnStateChanged - this gives us control over which state changes cause a UI rebuild
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekcoh ekcoh requested a review from stefanunity December 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants